Skip to content

Commit 83cb5d2

Browse files
committed
Remove app module duplicate of extraLargeShapeCornerRadius
The app module declared its own extraLargeShapeCornerRadius, duplicating the one already defined in the design system module. Removing the duplicate makes the design system value the single source of truth; before, the app copy shadowed it during resource merging, so a change to the design system value would not have reached the app module.
1 parent 5f7a10e commit 83cb5d2

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎app/src/main/java/com/duckduckgo/app/browser/nativeinput/NativeInputLayoutCoordinator.kt‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import androidx.coordinatorlayout.widget.CoordinatorLayout
2626
import androidx.core.view.isVisible
2727
import androidx.core.view.updateLayoutParams
2828
import com.duckduckgo.app.browser.R
29+
import com.duckduckgo.mobile.android.R as CommonR
2930
import com.google.android.material.card.MaterialCardView
3031

3132
class NativeInputLayoutCoordinator(
@@ -85,7 +86,7 @@ class NativeInputLayoutCoordinator(
8586
fun applyBottomCardCorners(widgetView: View, isBottom: Boolean) {
8687
if (!isBottom) return
8788
val card = widgetView.findViewById<MaterialCardView?>(R.id.inputModeWidgetCard) ?: return
88-
val radius = card.resources.getDimension(R.dimen.extraLargeShapeCornerRadius)
89+
val radius = card.resources.getDimension(CommonR.dimen.extraLargeShapeCornerRadius)
8990
card.shapeAppearanceModel =
9091
card.shapeAppearanceModel
9192
.toBuilder()

‎app/src/main/res/values/dimens.xml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
<dimen name="toolbar_horizontal_margin">8dp</dimen>
2020
<dimen name="recyclerViewOneFabBottomPadding">76dp</dimen>
2121
<dimen name="recyclerViewTwoFabsBottomPadding">136dp</dimen>
22-
<dimen name="extraLargeShapeCornerRadius">24dp</dimen>
2322
<dimen name="getDesktopBrowserMaxItemWidth">600dp</dimen>
2423
<dimen name="onboardingBackgroundMaxHeight">126dp</dimen>
2524
<dimen name="preOnboardingDaxCtaPaddingTop">40dp</dimen>

0 commit comments

Comments
 (0)