NTP omnibar: send the attachment kind with the learn more notification

Native splits the learn_more_tapped pixel by what was attached, the same way
iOS does, and it never sees the attach — so the page has to say which kind the
disclaimer was about.

Author: jotaemepereira

special-pages/pages/new-tab/app/omnibar/components/OmnibarProvider.js

@@ -99,7 +99,7 @@ export const OmnibarContext = createContext({
     attachmentPrivacyDisclaimerShown: () => {
         throw new Error('must implement');
     },
-    /** @type {() => void} */
+    /** @type {(kind: 'image' | 'file') => void} */
     openAttachmentPrivacyLearnMore: () => {
         throw new Error('must implement');
     },
@@ -306,10 +306,13 @@ export function OmnibarProvider(props) {
         [service],
     );
 
-    /** @type {() => void} */
-    const openAttachmentPrivacyLearnMore = useCallback(() => {
-        service.current?.openAttachmentPrivacyLearnMore();
-    }, [service]);
+    /** @type {(kind: 'image' | 'file') => void} */
+    const openAttachmentPrivacyLearnMore = useCallback(
+        (kind) => {
+            service.current?.openAttachmentPrivacyLearnMore(kind);
+        },
+        [service],
+    );
 
     /** @type {(modelId?: string) => void} */
     const selectUsageLimitsCta = useCallback(

special-pages/pages/new-tab/app/omnibar/components/useAttachmentPrivacyNotice.js

@@ -41,7 +41,14 @@ export function useAttachmentPrivacyNotice() {
         attachmentPrivacyDisclaimerShown(attachmentKind);
     }, [attachmentKind, granted, allowed, setGranted, attachmentPrivacyDisclaimerShown]);
 
-    const messageValues = { button: { click: openAttachmentPrivacyLearnMore } };
+    const messageValues = {
+        button: {
+            click: () => {
+                // Non-null whenever the notice is on screen; the presentation below needs it too.
+                if (attachmentKind) openAttachmentPrivacyLearnMore(attachmentKind);
+            },
+        },
+    };
 
     // `granted` outlasts `allowed`: the display that spends the last one stays on screen.
     const presentation =

special-pages/pages/new-tab/app/omnibar/integration-tests/omnibar-attachment-privacy.spec.js

@@ -237,7 +237,7 @@ test.describe('omnibar attachment privacy disclaimer', () => {
         await attachFile(omnibar);
         await omnibar.attachmentPrivacyLearnMore().click();
 
-        await omnibar.expectMethodCalledWith('omnibar_openAttachmentPrivacyLearnMore', {});
+        await omnibar.expectMethodCalledWith('omnibar_openAttachmentPrivacyLearnMore', { kind: 'file' });
         await expect(omnibar.fileChip()).toHaveCount(1);
         await expect(omnibar.noticeDrawer()).toBeVisible();
     });

special-pages/pages/new-tab/app/omnibar/omnibar.service.js

@@ -250,9 +250,10 @@ export class OmnibarService {
 
     /**
      * Notify native to open the attachment privacy help page in a new tab.
+     * @param {'image' | 'file'} kind
      */
-    openAttachmentPrivacyLearnMore() {
-        this.ntp.messaging.notify('omnibar_openAttachmentPrivacyLearnMore', {});
+    openAttachmentPrivacyLearnMore(kind) {
+        this.ntp.messaging.notify('omnibar_openAttachmentPrivacyLearnMore', { kind });
     }
 
     /**

special-pages/pages/new-tab/messages/omnibar_openAttachmentPrivacyLearnMore.notify.json

@@ -4,5 +4,12 @@
   "description": "Sent when the user selects 'Learn more' in the file-upload privacy disclaimer. Native opens the help page in a new tab and fires the learn_more_tapped pixel; the staged attachment is left untouched.",
   "type": "object",
   "additionalProperties": false,
-  "properties": {}
+  "required": ["kind"],
+  "properties": {
+    "kind": {
+      "description": "Which attachment the disclaimer was about. Native never sees the attach, so it cannot infer this for the pixel.",
+      "type": "string",
+      "enum": ["image", "file"]
+    }
+  }
 }

special-pages/pages/new-tab/types/new-tab.ts

@@ -755,7 +755,12 @@ export interface OmnibarOpenAttachmentPrivacyLearnMoreNotification {
 /**
  * Sent when the user selects 'Learn more' in the file-upload privacy disclaimer. Native opens the help page in a new tab and fires the learn_more_tapped pixel; the staged attachment is left untouched.
  */
-export interface OpenAttachmentPrivacyLearnMore {}
+export interface OpenAttachmentPrivacyLearnMore {
+  /**
+   * Which attachment the disclaimer was about. Native never sees the attach, so it cannot infer this for the pixel.
+   */
+  kind: "image" | "file";
+}
 /**
  * Generated from @see "../messages/omnibar_openCustomizeResponses.notify.json"
  */