don't show red dot on major tracker networks (#1526)

Author: brindy

DuckDuckGo.xcodeproj/project.pbxproj

@@ -7406,7 +7406,7 @@
 			repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
 			requirement = {
 				kind = exactVersion;
-				version = 48.1.1;
+				version = 49.0.0;
 			};
 		};
 		C14882EB27F211A000D59F0C /* XCRemoteSwiftPackageReference "SwiftSoup" */ = {

DuckDuckGo/PrivacyIconLogic.swift

@@ -38,7 +38,7 @@ final class PrivacyIconLogic {
             let config = ContentBlocking.shared.privacyConfigurationManager.privacyConfig
             let isUserUnprotected = config.isUserUnprotected(domain: privacyInfo.url.host)
 
-            let notFullyProtected = !privacyInfo.https || privacyInfo.isMajorTrackerNetwork || isUserUnprotected
+            let notFullyProtected = !privacyInfo.https || isUserUnprotected
 
             return notFullyProtected ? .shieldWithDot : .shield
         }

DuckDuckGoTests/PrivacyIconLogicTests.swift

@@ -72,30 +72,29 @@ class PrivacyIconLogicTests: XCTestCase {
 
     func testPrivacyIconIsShieldWithDotForHTTP() {
         let url = PrivacyIconLogicTests.insecurePageURL
-        let entity = Entity(displayName: "E", domains: [], prevalence: TrackerInfo.Constants.majorNetworkPrevalence - 1.0)
+        let entity = Entity(displayName: "E", domains: [], prevalence: 1.0)
         let protectionStatus = ProtectionStatus(unprotectedTemporary: false, enabledFeatures: [], allowlisted: false, denylisted: false)
         let privacyInfo = PrivacyInfo(url: url, parentEntity: entity, protectionStatus: protectionStatus)
 
         let icon = PrivacyIconLogic.privacyIcon(for: privacyInfo)
 
         XCTAssertTrue(url.isHttp)
         XCTAssertFalse(privacyInfo.https)
-        XCTAssertFalse(privacyInfo.isMajorTrackerNetwork)
         XCTAssertEqual(icon, .shieldWithDot)
     }
 
-    func testPrivacyIconIsShieldWithDotForMajorTrackerNetwork() {
+    func testPrivacyIconIsShieldWithoutDotForMajorTrackerNetwork() {
         let url = PrivacyIconLogicTests.pageURL
-        let entity = Entity(displayName: "E", domains: [], prevalence: TrackerInfo.Constants.majorNetworkPrevalence + 1.0)
+        // We don't have constants for major tracker network now now so just use a huge, unlikely prevalence
+        let entity = Entity(displayName: "E", domains: [], prevalence: 100.0)
         let protectionStatus = ProtectionStatus(unprotectedTemporary: false, enabledFeatures: [], allowlisted: false, denylisted: false)
         let privacyInfo = PrivacyInfo(url: url, parentEntity: entity, protectionStatus: protectionStatus)
 
         let icon = PrivacyIconLogic.privacyIcon(for: privacyInfo)
 
         XCTAssertTrue(url.isHttps)
         XCTAssertTrue(privacyInfo.https)
-        XCTAssertTrue(privacyInfo.isMajorTrackerNetwork)
-        XCTAssertEqual(icon, .shieldWithDot)
+        XCTAssertEqual(icon, .shield)
     }
 
 }

IntegrationTests/TrackerRadarIntegrationTests.swift

@@ -45,17 +45,6 @@ class TrackerRadarIntegrationTests: XCTestCase {
 
 extension TrackerDataManager {
 
-    func assertIsMajorTracker(domain: String, file: StaticString = #file, line: UInt = #line) {
-        guard let tds = fetchedData?.tds else {
-            XCTFail("No TDS found")
-            return
-        }
-        
-        let entity = tds.findEntity(forHost: domain)
-        XCTAssertNotNil(entity, "no entity found for domain \(domain)", file: file, line: line)
-        XCTAssertGreaterThan(entity?.prevalence ?? 0, TrackerInfo.Constants.majorNetworkPrevalence, file: file, line: line)
-    }
-
     func assertEntityAndDomainLookups(file: StaticString = #file, line: UInt = #line) {
         guard let tds = fetchedData?.tds else {
             XCTFail("No TDS found")