Improve swift style + swiftlint (#1092)

Task/Issue URL: https://app.asana.com/0/0/1201986385932308/f

Description:
Implement style guide changes
Update swift lint
Fork style from RW repo with some added changes

Author: Bunn

.swiftlint.yml

@@ -1,21 +1,56 @@
 
 disabled_rules:
-  - trailing_whitespace
+  - discarded_notification_center_observer
+  - notification_center_detachment
+  - orphaned_doc_comment
+  - todo
+  - unused_capture_list
+
+opt_in_rules:
+  - closure_end_indentation
+  - closure_spacing
+  - colon
+  - overridden_super_call
+  - unused_import
+  - fatal_error_message
+
+force_cast: warning
+force_try: warning
+legacy_hashing: error
 
-# Rule Config
-line_length:
-  warning: 150
-  ignores_comments: true
 identifier_name:
   min_length: 1
   max_length:
     warning: 40
     error: 60
+  excluded:
+    - i
+    - id
+    - x
+    - y
+    - z
+
+line_length:
+  warning: 150
+  ignores_urls: true
+  ignores_function_declarations: true
+  ignores_comments: true
+
+vertical_whitespace:
+  max_empty_lines: 2
+
+trailing_whitespace:
+  ignores_empty_lines: true
+  ignores_comments: true
+
+private_over_fileprivate:
+  validate_extensions: true
+
 type_name:
-  min_length: 3
-  max_length:
-    warning: 80
-    error: 100
+ min_length: 3
+ max_length:
+   warning: 80
+   error: 100
 
 # General Config
 excluded:

AtbUITests/AtbIntegrationTests.swift

@@ -137,7 +137,7 @@ class AtbIntegrationTests: XCTestCase {
 
 }
 
-fileprivate extension HttpRequest {
+private extension HttpRequest {
 
     func queryParam(_ named: String) -> String? {
         return queryParams.first(where: { $0.0 == named })?.1

Core/APIRequest.swift

@@ -88,7 +88,7 @@ public class APIRequest {
 
             if let error = error {
                 completion(nil, error)
-            } else if let error = httpResponse?.validateStatusCode(statusCode: 200..<300) { 
+            } else if let error = httpResponse?.validateStatusCode(statusCode: 200..<300) {
                 completion(nil, error)
             } else {
                 var etag = httpResponse?.headerValue(for: APIHeaders.Name.etag)

Core/BookmarkObjects.swift

@@ -34,7 +34,7 @@ private struct Constants {
 public protocol Bookmark: BookmarkItem {
     var url: URL? { get set }
 
-    var displayTitle: String? { get }    
+    var displayTitle: String? { get }
 }
 
 public extension Bookmark {

Core/BookmarksCoreDataStorage.swift

@@ -132,7 +132,7 @@ public class BookmarksCoreDataStorage {
             context.perform {
                 handler(context)
                 self.storeLoadedCondition.resolve()
-            }            
+            }
         }
     }
 }
@@ -422,7 +422,7 @@ extension BookmarksCoreDataStorage {
         loadStore()
     }
 
-    public func favoritesUncachedForWidget(completion: @escaping ([BookmarkManagedObject]) -> Void) {        
+    public func favoritesUncachedForWidget(completion: @escaping ([BookmarkManagedObject]) -> Void) {
         Task {
             guard await hasTopLevelFolder() else {
                 completion([])

Core/Database.swift

@@ -122,5 +122,5 @@ private class DDGPersistentContainer: NSPersistentContainer {
     override public class func defaultDirectoryURL() -> URL {
 
         return FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: Database.Constants.databaseGroupID)!
-    } 
+    }
 }

Core/PartiallyRoundedRectangleView.swift

@@ -47,9 +47,9 @@ public class PartiallyRoundedRectangleView: UIView {
     override public func layoutSubviews() {
         super.layoutSubviews()
         var corners = UIRectCorner()
-        if topLeftCorner { corners.insert(.topLeft)     }
-        if topRightCorner { corners.insert(.topRight)    }
-        if bottomLeftCorner { corners.insert(.bottomLeft)  }
+        if topLeftCorner { corners.insert(.topLeft) }
+        if topRightCorner { corners.insert(.topRight) }
+        if bottomLeftCorner { corners.insert(.bottomLeft) }
         if bottomRightCorner { corners.insert(.bottomRight) }
         round(corners: corners, radius: cornerRadius)
     }

Core/PrivacyPractices.swift

@@ -72,7 +72,7 @@ public class PrivacyPractices {
 
     func findPractice(forHost host: String) -> Practice {
         guard let domain = tld.domain(host) else { return Constants.unknown }
-        guard let term = termsOfServiceStore.terms[domain] else { return Constants.unknown}
+        guard let term = termsOfServiceStore.terms[domain] else { return Constants.unknown }
         let entityScore = entityScores[entityMapping.findEntity(forHost: domain)?.displayName ?? ""]
         return Practice(score: entityScore ?? term.derivedScore,
                         summary: term.summary,

Core/WebCacheManager.swift

@@ -113,7 +113,7 @@ public class WebCacheManager {
         cookieStore.getAllCookies { cookies in
             let group = DispatchGroup()
             cookies.forEach { cookie in
-                if domains.contains(where: { self.isCookie(cookie, matchingDomain: $0)}) {
+                if domains.contains(where: { self.isCookie(cookie, matchingDomain: $0) }) {
                     group.enter()
                     cookieStore.delete(cookie) {
                         group.leave()

DuckDuckGo/ActionSheetDaxDialogViewController.swift

@@ -74,7 +74,7 @@ class ActionSheetDaxDialogViewController: UIViewController {
     override func viewWillAppear(_ animated: Bool) {
         super.viewWillAppear(animated)
 
-        containerHeight.constant = daxDialogViewController?.calculateHeight() ?? 0        
+        containerHeight.constant = daxDialogViewController?.calculateHeight() ?? 0
     }
 
     override func viewDidAppear(_ animated: Bool) {