Skip to content

Commit 07eb699

Browse files
olegzryanjbaxter
authored andcommitted
Ensure bindings are removed from BindingServiceProperties
1 parent 21fcdb9 commit 07eb699

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

  • core
    • spring-cloud-stream-integration-tests/src/test/java/org/springframework/cloud/stream/function
    • spring-cloud-stream/src/main/java/org/springframework/cloud/stream/function

‎core/spring-cloud-stream-integration-tests/src/test/java/org/springframework/cloud/stream/function/StreamBridgeTests.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -575,6 +575,9 @@ void bindingsAreRemovedWithCache() {
575575
BindingService bindingService = context.getBean(BindingService.class);
576576
assertThat(bindingService.getProducerBindingNames().length).isEqualTo(1);
577577
assertThat(bindingService.getProducerBindingNames()[0]).isEqualTo("d");
578+
BindingServiceProperties bindingServiceProp = context.getBean(BindingServiceProperties.class);
579+
assertThat(bindingServiceProp.getBindings().size()).isEqualTo(1);
580+
assertThat(bindingServiceProp.getBindings().keySet().iterator().next()).isEqualTo("d");
578581
}
579582
}
580583

‎core/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/function/StreamBridge.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ protected boolean removeEldestEntry(Map.Entry<String, MessageChannel> eldest) {
155155
if (logger.isDebugEnabled()) {
156156
logger.debug("Removing message channel from cache " + eldest.getKey());
157157
}
158+
bindingServiceProperties.getBindings().remove(eldest.getKey());
158159
bindingService.unbindProducers(eldest.getKey());
159160
}
160161
return remove;

0 commit comments

Comments
 (0)