Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2265 +/- ##
==========================================
- Coverage 93.88% 93.84% -0.05%
==========================================
Files 182 182
Lines 13140 13140
==========================================
- Hits 12337 12331 -6
- Misses 803 809 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 1, 2026 10:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


test_crawler_intermediate_statisticsfailed on Windows 3.12 (run) with98582 µs >= 100000 µs. The test sleeps 100 ms withasyncio.sleepand expectscrawler_runtimeto be at least that long, butcrawler_runtimecomes fromdatetime.now(). On Windows before Python 3.13 that clock ticks every ~15.6 ms, and the only slack in the test was the poll lag, which can be close to zero.The test now takes its own
datetime.now()readings when it sees the crawler start and after the sleep, and asserts the runtime is at least the gap between them. Both sides use the same clock, and the check still fails if the runtime isn't updated while the crawler runs.✍️ Drafted by Claude Code