Skip to content

Added domains to compat matrix - #18583

Merged
ToriLindsay merged 5 commits into
productionfrom
tori/pcx17944-add-domains-to-compat
Jan 30, 2025
Merged

ToriLindsay merged 5 commits into
productionfrom
tori/pcx17944-add-domains-to-compat

Conversation

@ToriLindsay

Copy link
Copy Markdown
Contributor

Fixes #17944

@ToriLindsay

Copy link
Copy Markdown
Contributor Author

@mikenomitch Would you be able to review? Feel free to let me know if you think this is too granular or isn't necessary.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Dec 5, 2024 •

Copy link
Copy Markdown

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e09e9f
Status: ✅  Deploy successful!
Preview URL: https://38d31a7d.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://tori-pcx17944-add-domains-to.cloudflare-docs-7ou.pages.dev

View logs

@github-actions

github-actions Bot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

@mikenomitch

Copy link
Copy Markdown
Contributor

@ToriLindsay this LGTM but I want to double check with @nevikashah that it is accurate!

Comment thread src/content/docs/workers/static-assets/compatibility-matrix.mdx
@ToriLindsay

ToriLindsay commented Jan 21, 2025 •

Copy link
Copy Markdown
Contributor Author

@ToriLindsay this LGTM but I want to double check with @nevikashah that it is accurate!

@nevikashah Can you review this when you have the chance?

Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>

@hyperlint-ai-deprecated hyperlint-ai-deprecated Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 total issue(s) found.

| [Custom domains](/workers/configuration/routing/custom-domains/#add-a-custom-domain)| ✅ | ✅ |
| [Custom subdomains](/workers/configuration/routing/custom-domains/#set-up-a-custom-domain-in-the-dashboard)|✅|✅|
| [Custom domains outside Cloudflare zones](/pages/configuration/custom-domains/#add-a-custom-cname-record)|❌|✅|
| [Non-root Routes](https://developers.cloudflare.com/workers/configuration/routing/routes/) | ⏳ | ❌ |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [Non-root Routes](https://developers.cloudflare.com/workers/configuration/routing/routes/) | ⏳ | ❌ |
| [Non-root Routes](/workers/configuration/routing/routes/) | ⏳ | ❌ |

Issues:

  • Style Guide - (cloudflare.LinkChecks-warning) Warning: When referring to another page in our docs, use the full relative link (/1.1.1.1/check/) instead of the full URL (https://developers.cloudflare.com/1.1.1.1/check/) or a local development link (http://localhost:111/1.1.1.1/check/).

Fix Explanation:

The existing text uses a full URL to link to another page in the documentation. According to the style guide, it should use a full relative link instead. The replacement text corrects this by changing the full URL to a relative link.

Comment thread src/content/docs/workers/static-assets/compatibility-matrix.mdx Outdated
Comment thread src/content/docs/workers/static-assets/compatibility-matrix.mdx Outdated
@ToriLindsay

Copy link
Copy Markdown
Contributor Author

@ToriLindsay this LGTM but I want to double check with @nevikashah that it is accurate!

@nevikashah Can you review this when you have the chance?

@GregBrimble @WalshyDev Or maybe you can confirm that it's accurate? I updated it according to Greg's previous comment. Thank you!

@ToriLindsay
ToriLindsay merged commit fb25184 into production Jan 30, 2025
@ToriLindsay
ToriLindsay deleted the tori/pcx17944-add-domains-to-compat branch January 30, 2025 11:53
kodster28 pushed a commit that referenced this pull request Jan 30, 2025
* Added domains to compat matrix

* Update src/content/docs/workers/static-assets/compatibility-matrix.mdx

Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>

* Update src/content/docs/workers/static-assets/compatibility-matrix.mdx

* Update src/content/docs/workers/static-assets/compatibility-matrix.mdx

---------

Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add custom domains to Workers vs. Pages-compatibility matrix

7 participants