Restore JSON multipart encoding after SDK regeneration - #4364
Closed
Shubham-Padkonde wants to merge 1 commit into
Closed
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Member
|
should be fixed in #4374 Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Fixes #4360. Restore the JSON multipart encoding used by the five endpoints corrected in #4187 before regeneration removed it, including the internal MarshalRootWithJSON implementation. Settings and metadata are again single application/json parts; content-upload files remain binary parts with the repeated files field name.
Credit to @1000hz for the original endpoint fix in #4187. This restores that behavior and adds coverage for all five public MarshalMultipart methods. The restored encoder cache also distinguishes ordinary and JSON modes so warming one cannot change the other.
Additional context & links
The five endpoint regression cases fail on a451147 and pass with this change. Internal tests pass with the race detector. The full SDK build also passes. The cache-mode regression fails when the JSON mode is omitted from the cache key.
A broader root-package test run without Prism failed on mock-server connection refusals and two context-retry tests. Both retry failures reproduce unchanged on upstream a451147. Full test-package compilation was started but cancelled after WSL stopped responding; it is not claimed to pass. The Prism-backed API suite was not run. No live Cloudflare account was used.
Agent-assisted implementation and testing with Codex. The generator also needs to preserve the configuration so the next regeneration does not remove the fix again.