Skip to content

log executeCode return values - #300

Merged
maxwellpeterson merged 5 commits into
mainfrom
mpeterson/execute-code-return-values
Sep 1, 2026
Merged

log executeCode return values#300
maxwellpeterson merged 5 commits into
mainfrom
mpeterson/execute-code-return-values

Conversation

@maxwellpeterson

@maxwellpeterson maxwellpeterson commented Aug 21, 2026 •
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown
Member

Kimi likes to return values when using the executeCode tool instead of logging them. Return values are currently discarded, which causes confusion. We can automatically log them instead.

This is probably a better alternative to #299

Fixes #209

Devin Review

@github-actions github-actions Bot added kernel Changes to the Workshop kernel gatekeeper Changes to a gatekeeper integration labels Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

Preview: pr300-mpeterson-exe-a7d98d39

https://pr300-mpeterson-exe-a7d98d39-router.cloudflare-os-previews.workers.dev

Dashboard · deleted when this PR closes

@maxwellpeterson
maxwellpeterson marked this pull request as ready for review August 21, 2026 19:28
ndisidore
ndisidore reviewed Aug 21, 2026
View reviewed changes
Comment thread packages/workshop-backend/src/overseer.ts Outdated
@maxwellpeterson
maxwellpeterson force-pushed the mpeterson/execute-code-return-values branch from bf9da6a to 60cdb65 Compare August 21, 2026 19:52
@maxwellpeterson maxwellpeterson mentioned this pull request Aug 24, 2026
Closed
kentonv
kentonv reviewed Aug 25, 2026
View reviewed changes
Comment thread packages/workshop-backend/src/overseer.ts Outdated
Comment thread packages/workshop-backend/src/agent.ts Outdated
Comment thread packages/gatekeeper-scheduler/src/types.d.ts Outdated
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@maxwellpeterson
add note to the agent when executeCode succeeds with no output
ebc13c4 
- help kimi and other non-sota models understand that no output doesn't
  mean something when wrong, just that the function ran without logging
  or returning anything
@maxwellpeterson
maxwellpeterson force-pushed the mpeterson/execute-code-return-values branch from 3148589 to ebc13c4 Compare August 31, 2026 17:49
@ask-bonk

ask-bonk Bot commented Aug 31, 2026

Copy link
Copy Markdown
  • P2 packages/workshop-backend/src/overseer.ts:103: Workerd JSON-serializes plain-object console arguments. Valid returns such as { count: 1n } or cyclic objects become {}, producing misleading Return value: {} output. Format return values safely before logging, with explicit BigInt/cycle handling.

github run

@ask-bonk

ask-bonk Bot commented Aug 31, 2026

Copy link
Copy Markdown
  • P2 packages/gatekeeper-scheduler/src/types.d.ts:308: return scheduleId is at module top level, making the documented executeCode example invalid JavaScript. Wrap the snippet in the required exported async function.

github run

@maxwellpeterson
address ai code review comments
b866e1e 
- report errors that serialize to "" as uncaught exceptions instead of
  reporting success
@ask-bonk

ask-bonk Bot commented Aug 31, 2026

Copy link
Copy Markdown

No additional actionable findings beyond the existing return-value serialization issue.

github run

kentonv
kentonv approved these changes Aug 31, 2026
View reviewed changes

@kentonv kentonv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for slow response.

@maxwellpeterson
maxwellpeterson merged commit d1b3d47 into main Sep 1, 2026
15 checks passed
@maxwellpeterson
maxwellpeterson deleted the mpeterson/execute-code-return-values branch September 1, 2026 16:57
@maxwellpeterson maxwellpeterson mentioned this pull request Sep 1, 2026
Closed
3 tasks done
@pol-cc pol-cc mentioned this pull request Sep 4, 2026
Open
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndisidore ndisidore ndisidore left review comments
@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@kentonv kentonv kentonv approved these changes

Assignees

No one assigned

Labels

gatekeeper Changes to a gatekeeper integration kernel Changes to the Workshop kernel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

executeCode can drop module return values

3 participants

@maxwellpeterson @ndisidore @kentonv