Skip to content

RFC-5988 compliance for Link Header in response #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codedoga wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RFC-5988 compliance for Link Header in response #114

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20baee2
Refactor response headers in router.ts
codedoga Nov 2, 2025
b8a829a
Refactor response headers in router.ts 2
codedoga Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refactor response headers in router.ts 2
  • Loading branch information
@codedoga
codedoga authored Nov 2, 2025
commit b8a829ae25f425ef3a1ef5a81d1d141830650c51
36 changes: 16 additions & 20 deletions src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,23 +34,17 @@ v2Router.get("/_catalog", async (req, env: Env) => {
if ("response" in response) {
return response.response;
}
const url = new URL(req.url);
const headers: Record<string, string> = {
"Content-Type": "application/json",
};

if (response.cursor) {
const cleanCursor = response.cursor.split("/manifests/")[0];
const linkValue = `<${url.protocol}//${url.hostname}${url.pathname}?n=${n ?? 1000}&last=${cleanCursor}>; rel="next"`;
headers["Link"] = linkValue;
}

const url = new URL(req.url);
return new Response(
JSON.stringify({
repositories: response.repositories,
}),
{
headers,
headers: {
"Link": `${url.protocol}//${url.hostname}${url.pathname}?n=${n ?? 1000}&last=${response.cursor ?? ""}; rel=next`,
"Content-Type": "application/json",
},
},
);
});
Expand Down Expand Up @@ -93,22 +87,23 @@ v2Router.delete("/:name+/manifests/:reference", async (req, env: Env) => {

const url = new URL(req.url);
if (tags.truncated) {
url.searchParams.set("last", tags.truncated ? tags.cursor : "");
url.searchParams.set("last", tags.cursor);
const headers: Record<string, string> = {
"Content-Type": "application/json",
};
const linkValue = `<${url.toString()}>; rel="next"`;
headers["Link"] = linkValue;
return new Response(JSON.stringify(ManifestTagsListTooBigError), {
status: 400,
headers: {
"Link": `${url.toString()}; rel=next`,
"Content-Type": "application/json",
},
headers,
});
}

// Last but not least, delete the digest manifest
await env.REGISTRY.delete(`${name}/manifests/${reference}`);
return new Response("", {
status: 202,
headers: {
"Content-Length": "None",
"Content-Length": "0",
},
});
});
Expand Down Expand Up @@ -582,12 +577,13 @@ v2Router.get("/:name+/tags/list", async (req, env: Env) => {
const url = new URL(req.url);
url.searchParams.set("n", `${n}`);
url.searchParams.set("last", keys.length ? keys[keys.length - 1] : "");
const responseHeaders: { "Content-Type": string; "Link"?: string } = {
const responseHeaders: Record<string, string> = {
"Content-Type": "application/json",
};
// Only supply a next link if the previous result is truncated
if (tags.truncated) {
responseHeaders.Link = `${url.toString()}; rel=next`;
const linkValue = `<${url.toString()}>; rel="next"`;
responseHeaders["Link"] = linkValue;
}
return new Response(
JSON.stringify({
Expand Down