fix(turnstile-spin): report skill bundle copy failures - #206
Open
shaoshuaig wants to merge 1 commit into
Open
shaoshuaig wants to merge 1 commit into
shaoshuaig wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
persist-skill.shcannot create or copy the destination bundle, it currently continues after the Python error and returnsstatus: okwith exit code 0. For example, an existing.claudefile prevents installation at.claude/skills/turnstile-spin/SKILL.md, but the caller is told that persistence succeeded.Check the copy block's exit status and return
{"status":"error","reason":"copy_failed"}with exit code 1 on failure. Add offline regression tests for that failure, successful installation into new and empty directories (including executable script permissions), and preservation of nonempty destinations.The closed #148 also addressed copy failure propagation as part of a broader persistence redesign. This change isolates the error-reporting fix while retaining the current download and destination behavior.
Validation:
python3 -I -m unittest discover -s skills/turnstile-spin/tests -p 'test_*.py' -v: 3 tests pass. On the unchanged script, the copy-failure test fails because it returns success; the other tests pass.bash -non all four Turnstile helper scripts.git diff --check.Tests use a local Git stub and no network or credentials. No Cloudflare API behavior or skill guidance is changed.