Conversation
Author
|
Closing as this is stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Used
2to3 -wforclient.pyandexample.py. Updated theunit_test.pylibrary to account for some Python3 imports.However, I'm not 100% sure about the relative paths for importing the JSON files in
unit_test.py. I had to addjust before importing the client to resolve some directory/relative import issues. However, all the unit tests passed once those were resolved. I removed the code that appends to
PATHbefore committing as well.My text editor also follows the Pep8 standard for Python3 formatting, so I hope that helps as well 👍