chore(special-pages): remove unused @rive-app/canvas-single dependency - #3042
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Onboarding v3 removal (#2924) deleted RiveAnimation and all .riv assets, but the npm dependency was left behind. v4 onboarding uses lottie-web and mp4 videos instead, so this package is no longer imported anywhere. Also remove the unused .riv esbuild loader and update an outdated comment in DuckPlayerContent. Rebased from #2934 to resolve merge conflicts with main.
Contributor
Build Branch
Static preview entry points
QR codes (mobile preview)
Integration commandsnpm (Android / Extension): Swift Package Manager (Apple): .package(url: "https://github.com/duckduckgo/content-scope-scripts.git", branch: "pr-releases/cursor/dependency-update-review-692b")git submodule (Windows): git -C submodules/content-scope-scripts fetch origin pr-releases/cursor/dependency-update-review-692b
git -C submodules/content-scope-scripts checkout origin/pr-releases/cursor/dependency-update-review-692bPin to exact commitnpm (Android / Extension): Swift Package Manager (Apple): .package(url: "https://github.com/duckduckgo/content-scope-scripts.git", revision: "fd3f7a19b926ec2d4aa45b4f16fbddb75eb655f2")git submodule (Windows): git -C submodules/content-scope-scripts fetch origin pr-releases/cursor/dependency-update-review-692b
git -C submodules/content-scope-scripts checkout fd3f7a19b926ec2d4aa45b4f16fbddb75eb655f2 |
Contributor
[Beta] Generated file diffTime updated: Mon, 14 Sep 2026 11:42:58 GMT |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: N/A (dependency update review follow-up for #3041)
Description
Onboarding v3 removal (#2924) deleted
RiveAnimation, all.rivassets, and every import of@rive-app/canvas-single, but the npm dependency was left inspecial-pages/package.json. v4 onboarding useslottie-weband mp4 videos instead.This PR removes the dead dependency and cleans up related leftovers:
@rive-app/canvas-singlefromspecial-pages/package.jsonand lockfile.rivesbuild loader fromopts.mjsDuckPlayerContent.jsRecommended action for #3041: close the Dependabot bump in favor of this removal.
Supersedes #2934 (rebased onto current
mainto resolve merge conflicts).Testing Steps
npm installnpm run build --workspace=special-pagesnpm run test-int --workspace=special-pages -- pages/onboarding/integration-tests/onboarding.v4.spec.js --project macos --reporter listChecklist
Please tick all that apply: