This repository was archived by the owner on Feb 24, 2025. It is now read-only.
supply privacy info for image permission dialog - #185
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reviewer: Mia
Asana: https://app.asana.com/0/414235014887631/470959007490761
CC: Cain
Description:
Simply add the privacy statement for adding images to the user's photo library.
Note that once the user grants or denies permission they will have to change this in Settings -> Privacy -> Photo Library. We should probably check for permission before showing the menu and hide "Save Image" if it is denied (or show some messaging to tell the user to update their permissions in settings) but that seems low priority for now.
Steps to test this PR:
Test 1
Test 2
Reviewer Checklist:
PR DRI Checklist: