Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

tab manager multi select mode - #3921

Merged
brindy merged 55 commits into
mainfrom
brindy/tab-manager-multi-select-mode
Feb 6, 2025
Merged

brindy merged 55 commits into
mainfrom
brindy/tab-manager-multi-select-mode

Conversation

@brindy

@brindy brindy commented Feb 3, 2025 •

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/0/392891325557410/1209303765372372/f
Tech Design URL:
CC:

Description:
Adds UI and menus for multi-tab select.

Minor deviation from Figma - long press menu items are only specific to the current tap and make more sense.

Steps to test this PR:

Phone:

  1. Internal user off
  2. Go to tab switcher ensure it looks like production
  3. Internal user on
  4. Open various combinations of new tabs / web pages, single, and multiple.
  5. Check that long pressing a tab and choosing select tab enters select mode and selects the tab
  6. Tap anywhere on screen to exit select mode
  7. Tap anywhere on screen again to go back to previous screen
  8. Back in tab switcher tap edit and check menu items
  9. Use Select Tabs to enter select mode
  10. Check bottom menu and button are enabled when appropriate and show correct menu items
  11. Check long press menu items are appropriate

Repeat test on iPad:

  1. Bottom bar (and therefore menu) doesn't exist, check Figma for iPad details

Definition of Done (Internal Only):

brindy added 30 commits January 16, 2025 11:43
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts:
#	DuckDuckGo/TabSwitcherTopBarView.swift
#	DuckDuckGo/TabSwitcherViewController.swift
# Conflicts:
#	DuckDuckGo/MainViewController.swift
#	DuckDuckGo/TabSwitcherTopBarView.swift
#	DuckDuckGo/TabSwitcherViewController.swift
#	DuckDuckGo/UserText.swift
@brindy
brindy requested a review from dus7 February 3, 2025 19:59
@github-actions

github-actions Bot commented Feb 3, 2025 •

Copy link
Copy Markdown
Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 120fbf9

@dus7 dus7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Works as advertised. I checked both iPhone and iPad. Leaving one suggestion and one place to fix which is causing retain cycles.

Comment thread DuckDuckGo/TabSwitcherViewController+MultiSelect.swift Outdated
Comment thread DuckDuckGo/TabSwitcherViewController+MultiSelect.swift
brindy and others added 3 commits February 6, 2025 10:25
tidy one liner for web page tabs count

Co-authored-by: Mariusz Śpiewak <dus7@users.noreply.github.com>

@dus7 dus7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Checked described scenarios and verified there are no retain cycles.

@brindy
brindy merged commit 9a3a08b into main Feb 6, 2025
@brindy
brindy deleted the brindy/tab-manager-multi-select-mode branch February 6, 2025 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants