This repository was archived by the owner on Feb 24, 2025. It is now read-only.
tab manager multi select mode - #3921
Merged
Merged
Conversation
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…r-multi-select-edit-menu
# Conflicts: # DuckDuckGo/TabSwitcherTopBarView.swift # DuckDuckGo/TabSwitcherViewController.swift
…tab-manager-multi-select-mode
# Conflicts: # DuckDuckGo/MainViewController.swift # DuckDuckGo/TabSwitcherTopBarView.swift # DuckDuckGo/TabSwitcherViewController.swift # DuckDuckGo/UserText.swift
# Conflicts: # DuckDuckGo/TabSwitcherTopBarView.swift
dus7
reviewed
Feb 5, 2025
dus7
left a comment
Contributor
There was a problem hiding this comment.
Good job! Works as advertised. I checked both iPhone and iPad. Leaving one suggestion and one place to fix which is causing retain cycles.
tidy one liner for web page tabs count Co-authored-by: Mariusz Śpiewak <dus7@users.noreply.github.com>
dus7
approved these changes
Feb 6, 2025
dus7
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Checked described scenarios and verified there are no retain cycles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/0/392891325557410/1209303765372372/f
Tech Design URL:
CC:
Description:
Adds UI and menus for multi-tab select.
Minor deviation from Figma - long press menu items are only specific to the current tap and make more sense.
Steps to test this PR:
Phone:
Repeat test on iPad:
Definition of Done (Internal Only):