Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Fix webview retain cycle in special error pages handler and Expired certificate UI Test - #3951

Merged
dus7 merged 3 commits into
mainfrom
alessandro/fix-webview-retain-cycle
Feb 10, 2025
Merged

dus7 merged 3 commits into
mainfrom
alessandro/fix-webview-retain-cycle

Conversation

@alessandroboron

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/0/414709148257752/1209348984855251

Description:

This PR addresses:

  • Fix web view retain cycle in SpecialErrorPageNavigationHandler by weakly retaining the webView.
  • Fix Expired Certificate UI test broken due to icon logic changes for Malicious Site Protection

Steps to test this PR:

Retain Cycle

  1. Launch debug version.
  2. Open SERP.
  3. Long press on any result.
  4. Select "Open in background”.
  5. Ensure deallocation assertion is not fired.

UI Test

  1. Ensure Expired Certificate UI test pass.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@alessandroboron
alessandroboron requested a review from dus7 February 10, 2025 03:13

@dus7 dus7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dus7
dus7 merged commit cb01a30 into main Feb 10, 2025
@dus7
dus7 deleted the alessandro/fix-webview-retain-cycle branch February 10, 2025 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants