Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Enable Omnibar changes for AI Chat - #3954

Merged
Bunn merged 4 commits into
release/ios/7.157.0from
bunn/aichat/enable-omnibar-changes
Feb 11, 2025
Merged

Bunn merged 4 commits into
release/ios/7.157.0from
bunn/aichat/enable-omnibar-changes

Conversation

@Bunn

@Bunn Bunn commented Feb 10, 2025 •

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/0/0/1209365332925451/f

Description:
Enable omnibar changes and add new pixels

Steps to test this PR:

  1. Most of this was already tested here but a good smoke test would be good with the items bellow:
  2. Focus on the fact that you don’t need to be an internal user for the Omnibar + toolbar changes to take effect
  3. Check if the new pixels are being fired correctly
  4. Disable Duck.ai in the address bar, go the SERP, search something, then open the address bar and start typing, check if the right side margin is good. [See bug report]

Definition of Done (Internal Only):

@Bunn
Bunn requested a review from brindy February 10, 2025 17:41

@brindy brindy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@Bunn Bunn removed the Do Not Merge label Feb 11, 2025
@Bunn
Bunn merged commit d896ba8 into release/ios/7.157.0 Feb 11, 2025
@Bunn
Bunn deleted the bunn/aichat/enable-omnibar-changes branch February 11, 2025 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants