Skip to content

Enable sitePermissions for internal iOS users - #6003

Merged
bkunat merged 1 commit into
mainfrom
bartosz/sitePermissions
Oct 1, 2026
Merged

bkunat merged 1 commit into
mainfrom
bartosz/sitePermissions

Conversation

@bkunat

@bkunat bkunat commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1219083648084524

Description

Enables sitePermissions for all internal iOS users running version 7.241.0 or later.

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

github-actions Bot pushed a commit that referenced this pull request Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Generated file outputs:

Time updated: Thu, 01 Oct 2026 20:13:02 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/macos-config.json
  • v3/windows-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

2 files changed
  • v3/ios-config.json
  • v4/ios-config.json
--- v4/ios-config.json (and 1 other files)
+++ v4/ios-config.json
@@ -43620,8 +43620,12 @@
                 },
                 "appRatingPromptCoordination": {
                     "state": "enabled",
                     "minSupportedVersion": "7.238.0"
+                },
+                "sitePermissions": {
+                    "state": "internal",
+                    "minSupportedVersion": "7.241.0"
                 }
             }
         },
         "import": {
latest
13 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/macos-config.json
  • v5/windows-config.json

⚠️ File is identical

v5/ios-config.json
--- v5/ios-config.json
+++ v5/ios-config.json
@@ -43620,8 +43620,12 @@
                 },
                 "appRatingPromptCoordination": {
                     "state": "enabled",
                     "minSupportedVersion": "7.238.0"
+                },
+                "sitePermissions": {
+                    "state": "internal",
+                    "minSupportedVersion": "7.241.0"
                 }
             }
         },
         "import": {

@daxtheduck

daxtheduck commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

JSON approval analysis:

Time updated: Thu, 01 Oct 2026 20:13:10 GMT

legacy

❌ Manual Review Required

  • v3/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/iOSBrowserConfig/features/sitePermissions (add)
  • v4/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/iOSBrowserConfig/features/sitePermissions (add)
latest

❌ Manual Review Required

  • v5/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/iOSBrowserConfig/features/sitePermissions (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

@bkunat
bkunat marked this pull request as ready for review October 1, 2026 20:09
@bkunat
bkunat requested review from a team and daxtheduck as code owners October 1, 2026 20:09
@bkunat
bkunat requested a review from quanganhdo October 1, 2026 20:09

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@bkunat
bkunat requested a review from dus7 October 1, 2026 20:10
@bkunat
bkunat added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit c58a648 Oct 1, 2026
34 of 43 checks passed
@bkunat
bkunat deleted the bartosz/sitePermissions branch October 1, 2026 20:13
github-actions Bot pushed a commit that referenced this pull request Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants