Repository navigation
ES sampling index rotation ignores remote_read_clusters #9468
Description
Activity
Worth noting before anyone patches this: the
nillooks deliberate rather than missed. There is a TODO directly above the function:// TODO: Support RemoteClusters for sampling via a feature flag. func (f *FactoryBase) buildSamplingRotation() indices.Rotation {
So the inconsistency is real, but the shape of the fix is a decision rather than a one-liner: passing
f.config.RemoteReadClustersstraight through turns cross-cluster sampling reads on for everyone who already setsremote_read_clusters, which is what that TODO seems to be holding back. Happy to send either version, the unconditional one or one behind a flag, if you say which you want.@arpitjain099 I am working on this and will send the pr soon
- added a commit that references this issue
on Oct 3, 2026
buildSamplingRotation() (internal/storage/v2/elasticsearch/factory_base.go) passes nil for remote clusters instead of the configured remote_read_clusters value, unlike buildDependencyRotation() and the span/service rotations, which already thread that config through.
So a cluster configured with remote_read_clusters gets cross-cluster reads for dependency, span, and service indices, but not for the sampling index. Same config, inconsistent behavior depending on which index type is being read.
Fix is small: pass the same config value through buildSamplingRotation() that the other rotations already use.