Skip to content

Update HTMLView TS definitions to support class components #338

Description

@CostachescuCristinel

Currently, HTMLView's definitions specify the following props to accept function components only:
NodeComponent, RootComponent, TextComponent

However, the source code that uses these props, only uses destructuring assignment to extract these from the HTMLView's props, and then creates these components as JSX tags:

RootComponent:

<RootComponent

NodeComponent:
<NodeComponent

TextComponent:
listItemPrefix = (<TextComponent style={[defaultStyle, customStyle]}>

This approach is compatible for use with both functional and class components.
In fact, I am using class components for these, and there are no problems.

Except: the TS definitions will issue a warning about failed prop types:
Warning: Failed prop type: Invalid prop 'TextComponent' of type 'object' supplied to 'HtmlView', expected 'function'.

Can you please update the TS definitions to fix this?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions