KTOR-9937 OkHttp: Do not read the body of responses without a body - #5904
Open
Ruslan Ibrahimau (IRus) wants to merge 1 commit into
Open
Ruslan Ibrahimau (IRus) wants to merge 1 commit into
Ruslan Ibrahimau (IRus) wants to merge 1 commit into
Conversation
OkHttp expects a body for a 304 response when Content-Length is present, so copying ResponseBody into the response channel waited for bytes that never come and hung on a keep-alive connection. Responses to HEAD, and 1xx, 204 and 304 responses, end at the header section (RFC 9112 §6.3), as in the CIO engine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OkHttp expects a body for a 304 response when Content-Length is present, so copying ResponseBody into the response channel waited for bytes that never come and hung on a keep-alive connection. Responses to HEAD, and 1xx, 204 and 304 responses, end at the header section (RFC 9112 §6.3), as in the CIO engine.
Subsystem
Client, OkHttp engine
Motivation
https://youtrack.jetbrains.com/issue/KTOR-9937/OkHttp-reading-a-304-response-that-carries-Content-Length-hangs-until-timeout
Solution
Skip reading the OkHttp response body for HEAD, 1xx, 204 and 304 responses