KTOR-3891 Cancel the source channel when a decoder's output is cancelled - #5905
Open
Ruslan Ibrahimau (IRus) wants to merge 1 commit into
Open
Ruslan Ibrahimau (IRus) wants to merge 1 commit into
Ruslan Ibrahimau (IRus) wants to merge 1 commit into
Conversation
The gzip, deflate and zstd decoders and ByteReadChannel.deflated read the source in a writer coroutine, but cancelling the returned channel did not cancel the source. A streaming client response whose decoded body was not read then never completed, because the engine body channel stayed open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gzip, deflate and zstd decoders and ByteReadChannel.deflated read the source in a writer coroutine, but cancelling the returned channel did not cancel the source. A streaming client response whose decoded body was not read then never completed, because the engine body channel stayed open.
Subsystem
Client/Server, related modules
Motivation
https://youtrack.jetbrains.com/issue/KTOR-3891
Solution
Cancel source channel when decode channel was canceled