Conversation
A properties table shared through a cast got no garbage slot, so nested data removal stopped at it before the destructor ran. Fix php#24050
devnexen
marked this pull request as ready for review
October 1, 2026 22:22
arnaud-lb
approved these changes
Oct 2, 2026
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
gc_collect_white() adds all refcounted nodes to the GARBAGE buffer, but when a ht is reached as the return of get_gc we forget to do so, preventing it from ever being added to GARBAGE as it's already seen.
gc_remove_nested_data_from_buffer() follows only GARBAGE, so ht and anything reachable from it is left in GARBAGE.
The ht is then made reachable by the dtor, and everything left in GARBAGE is freed.
The fix looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A properties table shared through a cast got no garbage slot, so nested data removal stopped at it before the destructor ran.
Fix #24050