Conversation
…eighboring category) Now, data points within hoverdistance but outside the hovered category are omitted from the hover label. Within the category, the hoverdistance still filters away too distant data points.
…om hovered category
my-tien
marked this pull request as ready for review
August 13, 2026 15:01
Contributor
|
Thanks for the fix! We'll review and follow up with you. |
camdecoster
requested changes
Sep 24, 2026
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
This change gets us part of the way to the fix. I left a comment about an issue I saw. Before moving forward, could you please merge main and address the conflict?
Contributor
There was a problem hiding this comment.
This is an improvement, but I still see the same issue when hovering over the center or left side of the Other bar (from the issue figure). We need to add a filter looking at the category under the cursor before the spike line and winning point are chosen to handle that case. Could you please look into that? I have a solution that I've tested locally and I can push that if you'd like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7152
Now data points within
hoverdistancebut outside the hovered category are omitted from the hover label if the hovermode is "x", "y", "x unified" or "y unified".Within the category, the hoverdistance still filters away too distant data points.