Skip to content

naming: CertifiedKey is confusing #391

Description

@teohhanhui

CertifiedKey reads like "a key that is (somehow) certified", when we actually mean "a certificate together with the key(pair) used to sign it".

Perhaps CertificateWithKey would be fine?

Activity

  1. cpu commented on Oct 20, 2025

    @cpu
    Member

    Thanks for opening an issue,

    CertifiedKey reads like "a key that is (somehow) certified"

    That's an accurate reading from my perspective. An X.509 certificate binds a public key with a subject identity after being certified by a certification authority.

    Perhaps CertificateWithKey would be fine?

    In my own opinion I'm not sure it's a clear improvement and the win would need to be pretty substantial to justify a breaking API change.

  2. teohhanhui commented on Oct 20, 2025

    @teohhanhui
    Author

    An X.509 certificate binds a public key with a subject identity after being certified by a certification authority.

    Thanks for the clarification. Looks like the rustdoc should be phrased as such then.

  3. cpu commented on Oct 20, 2025

    @cpu
    Member

    Looks like the rustdoc should be phrased as such then.

    Sounds reasonable! Want to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions