Skip to content

Better toggle for dynamic filter area #255

Description

@Madis0

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Dynamic filtering mode claims to be only available to advanced users.
Yet, there is a read-only mode available for all users:

Also, regardless of "advanced user" mode, one can toggle it by clicking the "requests blocked" or "domains connected" bars.

However, once (accidentally) opened, it has no explicit header, collapse or close button, so it is very unclear how to hide it again.

Therefore I propose either adding a better indication on how to open/close the panel (an icon in the row of zapper-picker-console-settings perhaps? or an icon in the left edge of the dark gray bar) or remove the read-only mode altogether and keep the whole panel permanent for advanced mode.

A specific URL where the issue occurs

N/A

Steps to Reproduce

  1. Open the uBlock Origin popup by clicking on it's icon
  2. Misclick on "requests blocked" or "domains connected"
  3. Wonder why the dynamic filtering column opened when you did not have advanced mode enabled; wonder how to close it again

Expected behavior:

Explicit button for closing and preferably opening the side column

Actual behavior:

No indication of how the column opened and where to close it from; doesn't even close when toggling "advanced user mode" in settings

Your environment

  • uBlock Origin version: 1.17.0
  • Browser Name and version: Firefox 63.0b11
  • Operating System and version: macOS 10.14

Activity

  1. gorhill commented on Oct 4, 2018

    @gorhill
    Member

    I could add an icon on the left on hover -- that would satisfy me not wanting to clutter the UI, and provide a hint that the bar is interactive. I will evaluate the idea.

  2. reopened this on Oct 4, 2018
  3. added
    enhancementNew feature or request
    and removed
    duplicateThis issue or pull request already exists
    on Oct 4, 2018
  4. gorhill commented on Oct 4, 2018

    @gorhill
    Member

    Note that the mouse cursor changes when hovering the "requests blocked"/"domains connected" bars, so I will always considered there was already a hint that the bars are interactive. At some point, the thing is whatever I throw at uBO's UI, there will always be someone reporting having an issue with even the most trivial stuff and I can't every single time change uBO to accommodate every instance of someone overlooking something.

  5. uBlock-user commented on Oct 4, 2018

    @uBlock-user
    Member

    This confusion arises for non-advanced users who toggle the overview panel accidently, just remove that ability for non-advanced users and make the panel static if you want to address this.

  6. Madis0 commented on Oct 4, 2018

    @Madis0
    ContributorAuthor

    Note that the mouse cursor changes when hovering the "requests blocked"/"domains connected" bars, so I will always considered there was already a hint that the bars are interactive.

    The problem is that even if they are clearly interactive, they don't toggle the content directly under it (on this page, since install, x out of y), so it is may be still confusing for the user.

    At some point, the thing is whatever I throw at uBO's UI, there will always be someone reporting having an issue with even the most trivial stuff and I can't every single time change uBO to accommodate every instance of someone overlooking something.

    I don't agree with that, every other clickable thing in the popup is an icon (with a tooltip!), so it's easy to draw the connection.

  7. Madis0 commented on Oct 4, 2018

    @Madis0
    ContributorAuthor

    What about an icon that looks like « and changes to » when open? Would also make sense to be the first icon in whichever row you choose.

  8. gorhill commented on Oct 4, 2018

    @gorhill
    Member

    Just want to point out that at this point the argument is based on presumption that there is an actual issue. Is there data showing that a significant (i.e. not anecdotal) amount of non-advanced users are flustered by the overview pane?

  9. Madis0 commented on Oct 4, 2018

    @Madis0
    ContributorAuthor

    I've edited the post to prevent making claims I cannot verify.

    Either way, I found several issues that are related to this in some way: old #648 old #2467 old #3251 #125 #142.

    The first issue reminded me - you used to have plus/minus symbols in the headers, those made it more obvious (to me) that the header was clickable and collapsed/expanded something.
    687474703a2f2f692e696d6775722e636f6d2f79486f795a71662e706e67

  10. gorhill commented on Oct 4, 2018

    @gorhill
    Member

    Many of the issues you list would still have been opened even with an icon, it's users basically not paying attention to the documentation when explicitly warned with required reading. I have no doubt adding an icon won't prevent someone coming here to open such invalid issues, it's a statistical thing.

  11. Grossdm commented on Nov 7, 2018

    @Grossdm

    @gorhill, I agree with you about there being a statistical distribution for these things.

    I wanted to comment on your reliance on mouse cursor changes (and also tool tips, I assume) to guide users.
    These things are almost completely absent from mobile device interactions.
    I'm still using a Samsung Note 3 (my Paleophone), and I do use its stylus to trigger mouse over events.
    I have noticed that sometimes the same website on my tablet will provide more mouse event features, e.g. menus that pop open when my stylus hovers (but refusing to open with a tap from either my finger or the stylus).

    I thank you very much for the color blindness friendly option! IIRC, in the US 10% of males are afflicted with one of the few forms of color blindness.

    Doug

  12. Madis0 commented on Nov 10, 2019

    @Madis0
    ContributorAuthor

    I have found that Nano Adblocker has fixed this issue with a separate button:
    button

    Unfortunately, I am not familiar enough with either code base to make a PR.

  13. ghost closed this as completedon Apr 30, 2020
  14. ghost added
    fixedissue has been addressed
    on Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestfixedissue has been addressed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions