Skip to content

Add shadow to popups in the native input - #9911

Merged
YoussefKeyrouz merged 1 commit into
developfrom
fix/youssef/duckai_models_shadows
Oct 1, 2026
Merged

YoussefKeyrouz merged 1 commit into
developfrom
fix/youssef/duckai_models_shadows

Conversation

@YoussefKeyrouz

Copy link
Copy Markdown
Collaborator

Task/Issue URL: https://app.asana.com/1/137249556945/project/1204912272578138/task/1218154313912016?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):

Description

This PR moves popup_menu_bg from the inner container to the ScrollView in all four views. g.

Steps to test this PR

  • Open a Duck.ai chat with the native input enabled
  • Open the model picker and confirm the menu has a drop shadow
  • Open the effort picker and confirm the menu has a drop shadow
  • Tap the attachment (+) button and confirm the menu has a drop shadow
  • Open the tools menu (create image / web search) and confirm the menu has a drop shadow
  • Repeat in dark mode

UI changes

Before After
Screenshot_20260930_141903 Screenshot_20260930_141751
Screenshot_20260930_141856 Screenshot_20260930_141745
Screenshot_20260930_141850 Screenshot_20260930_141740
Screenshot_20260930_141844 Screenshot_20260930_141734

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@malmstein malmstein self-assigned this Oct 1, 2026

@malmstein malmstein left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YoussefKeyrouz
YoussefKeyrouz added this pull request to the merge queue Oct 1, 2026
Merged via the queue into develop with commit 80a9eb4 Oct 1, 2026
21 checks passed
@YoussefKeyrouz
YoussefKeyrouz deleted the fix/youssef/duckai_models_shadows branch October 1, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants