Skip to content

Add shadow to popups in the native input #9911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YoussefKeyrouz merged 1 commit into from
Oct 1, 2026
Merged

Add shadow to popups in the native input #9911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...at-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/nativeinput/views/AttachmentView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,11 +324,11 @@ class AttachmentView(

val container = LinearLayout(context).apply {
orientation = LinearLayout.VERTICAL
setBackgroundResource(com.duckduckgo.mobile.android.R.drawable.popup_menu_bg)
}
val popup = PopupWindow(
ScrollView(context).apply {
addView(container)
setBackgroundResource(com.duckduckgo.mobile.android.R.drawable.popup_menu_bg)
isVerticalScrollBarEnabled = false
},
resources.getDimensionPixelSize(R.dimen.nativeInputMenuWidth),
Expand Down
2 changes: 1 addition & 1 deletion ...t-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/nativeinput/views/ModelPickerView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ class ModelPickerView @JvmOverloads constructor(
private fun buildMenuContainer(): LinearLayout {
val container = LinearLayout(context).apply {
orientation = LinearLayout.VERTICAL
setBackgroundResource(com.duckduckgo.mobile.android.R.drawable.popup_menu_bg)
}
return container
}
Expand All @@ -245,6 +244,7 @@ class ModelPickerView @JvmOverloads constructor(
return PopupWindow(
ScrollView(context).apply {
addView(container)
setBackgroundResource(com.duckduckgo.mobile.android.R.drawable.popup_menu_bg)
isVerticalScrollBarEnabled = false
},
resources.getDimensionPixelSize(R.dimen.nativeInputMenuWidth),
Expand Down
2 changes: 1 addition & 1 deletion ...kchat-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/nativeinput/views/OptionsView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,11 @@ class OptionsView(context: Context, private val host: NativeInputHost) : LinearL
private fun showMenu() {
val container = LinearLayout(context).apply {
orientation = VERTICAL
setBackgroundResource(com.duckduckgo.mobile.android.R.drawable.popup_menu_bg)
}
val popup = PopupWindow(
ScrollView(context).apply {
addView(container)
setBackgroundResource(com.duckduckgo.mobile.android.R.drawable.popup_menu_bg)
isVerticalScrollBarEnabled = false
},
resources.getDimensionPixelSize(R.dimen.nativeInputMenuWidth),
Expand Down
2 changes: 1 addition & 1 deletion ...rc/main/java/com/duckduckgo/duckchat/impl/ui/nativeinput/views/ReasoningModePickerView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,11 @@ class ReasoningModePickerView @JvmOverloads constructor(

val container = LinearLayout(context).apply {
orientation = LinearLayout.VERTICAL
setBackgroundResource(com.duckduckgo.mobile.android.R.drawable.popup_menu_bg)
}
val popup = PopupWindow(
ScrollView(context).apply {
addView(container)
setBackgroundResource(com.duckduckgo.mobile.android.R.drawable.popup_menu_bg)
isVerticalScrollBarEnabled = false
},
resources.getDimensionPixelSize(R.dimen.nativeInputMenuWidth),
Expand Down
Loading